Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Grid Menu filtering options should be removed when option disabled #837

Merged
merged 1 commit into from Dec 6, 2022

Conversation

ghiscoding
Copy link
Owner

  • when creating a grid without enabling the filtering and we use Pagination, the Grid Menu might show options related to filtering and the reason is because internally we have to enable filtering to create the Pagination and then disable back the filtering option and we do that only once, but in some cases it might do this check a little too early before the SharedService is available and that would cause the filtering option to remain half enabled, we should simply wait for SharedService to be available before doing this swap

- when creating a grid without enabling the filtering and we use Pagination, the Grid Menu might show options related to filtering and the reason is because internally we have to enable filtering to create the Pagination and then disable back the filtering option and we do that only once, but in some cases it might do this check a little too early before the SharedService is available and that would cause the filtering option to remain half enabled, we should simply wait for SharedService to be available before doing this swap
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #837 (ccd4bea) into master (f1cadb3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #837   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines        16369     16368    -1     
  Branches      5777      5776    -1     
=========================================
- Hits         16369     16368    -1     
Impacted Files Coverage Δ
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 9bc29d2 into master Dec 6, 2022
@ghiscoding ghiscoding deleted the bugfix/grid-menu-filtering branch December 6, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant