Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Grid Menu filtering options should be removed when option disabled #837

Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix: Grid Menu filtering options should be removed when option disabled #837

merged 1 commit into from
Dec 6, 2022

Commits on Dec 6, 2022

  1. fix: Grid Menu filtering options should be removed when option disabled 

    - when creating a grid without enabling the filtering and we use Pagination, the Grid Menu might show options related to filtering and the reason is because internally we have to enable filtering to create the Pagination and then disable back the filtering option and we do that only once, but in some cases it might do this check a little too early before the SharedService is available and that would cause the filtering option to remain half enabled, we should simply wait for SharedService to be available before doing this swap
    @ghiscoding
    ghiscoding committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    ccd4bea View commit details
    Browse the repository at this point in the history