Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: skip reapplying empty html when target is already empty #1230

Merged
merged 1 commit into from
Nov 28, 2023
Merged

perf: skip reapplying empty html when target is already empty #1230

merged 1 commit into from
Nov 28, 2023

Commits on Nov 28, 2023

  1. perf: skip reapplying empty html when target is already empty 

    - when calling `applyHtmlCode()` method and our target element is empty and we try to reapply empty, it should always be ok to simply skip this reassignment.
- this should also help with performance since trying to reapply empty using `innerHTML` will probably cause a canvas repaint but if we manage to skip this then a repaint will also be skipped
- this should also help with CSP because we could write a Formatter with native element while still returning empty string when there's no value to return, that will then call `applyHtmlCode` and skip the assignment if the cell is already empty
    @ghiscoding-SE
    ghiscoding-SE committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    797d379 View commit details
    Browse the repository at this point in the history