Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression onSelectedRowsChanged not receiving correct caller #1341

Merged
merged 1 commit into from
Jan 17, 2024

Commits on Jan 17, 2024

  1. fix: regression with onSelectedRowsChanged not receiving correct `c…

    …aller` prop
    
    - a regression was introduced when dropping jQuery, the SlickEvent structure changed in the `notify` function. Previously a SlickEvent would accept a CustomEvent directly and the previous code was expecting that event to exists and override its CustomEvent `detail`, however the newer approach is to always use a SlickEventData and no longer use the CustomEvent directly and this caused the regression since the SlickEventData doesn't have a `detail` property but rather something like this `SlickEventData { event: { detail } }`
    ghiscoding-SE committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6c77386 View commit details
    Browse the repository at this point in the history