fix(core): allow extra spaces to be striped to any css classes #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using the `classNameToList()` util, we can permit any amount of spaces to css classes like Formatter `addClasses` - also cleanup and simplify some code around other css classes, `classNameToList` returns an array of string and we can take advantage of iterator available in DOM classList `.add()` and `.remove()`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1352 +/- ##
========================================
- Coverage 99.5% 99.5% -0.0%
========================================
Files 199 199
Lines 21571 21570 -1
Branches 7203 7201 -2
========================================
- Hits 21457 21456 -1
Misses 114 114 ☔ View full report in Codecov by Sentry. |
ghiscoding
deleted the
bugfix/highlight-strip-css-classes-extra-spaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classNameToList()util, we can permit any amount of spaces to css classes like FormatteraddClassesclassNameToListreturns an array of string and we can take advantage of iterator available in DOMclassList.add()and.remove()