Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsub): externalize PubSub event to SlickEventData to stop bubbling #1444

Merged
merged 2 commits into from
Mar 27, 2024
Merged

fix(pubsub): externalize PubSub event to SlickEventData to stop bubbling #1444

merged 2 commits into from
Mar 27, 2024

Commits on Mar 27, 2024

  1. fix(pubsub): externalize PubSub event to SlickEventData to stop bubbling 

    - add a way to externalize the Custom Event used internally by the PubSub Service so that the user could call `preventDefault()` on the SlickEventData as well, for example the CompositeEditor demo has the event `onBeforeEditCell` and if the user calls the `preventDefault` even on the SlickEventData (e.g. with Aurelia or Angular), then the SlickGrid `.notify` should receive a `returnValue` of `false` because when the PubSub calls the `dispatchEvent` with an event that was prevented, then the `returnValue` will be `false`, see MDN for reference: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/dispatchEvent#return_value
    @ghiscoding
    ghiscoding committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2d8987b View commit details
    Browse the repository at this point in the history

  2. chore: only assign nativeEvent when undefined

    @ghiscoding
    ghiscoding committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4e0e64f View commit details
    Browse the repository at this point in the history