Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filters): new filterPredicate shouldn't break other column filters #1531

Merged
merged 2 commits into from
May 16, 2024
Merged

fix(filters): new filterPredicate shouldn't break other column filters #1531

merged 2 commits into from
May 16, 2024

Commits on May 16, 2024

  1. fix(filters): new filterPredicate shouldn't break other column filters 

    - the previous PR to implement `filterPredicate` that was not caught originally which had the indirect effect of breaking the other filter columns, the issue was caused by the fact that calling a `return` within the `for` loop of all filters was cancelling the next filters because a `return` breaks the loop.
- So the fix is to only call `return` when the `filterPredicate` returns `false` which mean that at point the row data context is officially filtered out, so not inspecting further filters make sense
    @ghiscoding-SE
    ghiscoding-SE committed May 16, 2024
    Configuration menu
    Copy the full SHA
    ddf261e View commit details
    Browse the repository at this point in the history

  2. fix(demo): improve SQL LIKE with filter of Ta%30% 

    - `Ta%30%` wasn't working correctly before, it should be equivalent to: StartsWith "Ta" and Contains "30" anywhere
    @ghiscoding-SE
    ghiscoding-SE committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f7ce7a6 View commit details
    Browse the repository at this point in the history