Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(state): don't use previous columns ref when getting current cols #446

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

ghiscoding
Copy link
Owner

  • in our current project, if we were to create a Grid View by hidding some columns and then revert to default Grid View and then creating a 2nd Grid View it would reuse the hidden columns from the 1st Grid View even though we wanted to base our 2nd Grid View from the base (which is supposed to have all columns shown)... so basically the issue was that we shouldn't keep/reuse of the columns, we should reevaluate every time

- in our current project, if we were to create a Grid View by hidding some columns and then revert to default Grid View and then creating a 2nd Grid View it would reuse the hidden columns from the 1st Grid View even though we wanted to base our 2nd Grid View from the base (which is supposed to have all columns shown)... so basically the issue was that we shouldn't keep/reuse of the columns, we should reevaluate every time
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #446 (58b04a0) into master (01158bb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #446   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          219       219           
  Lines        13365     13358    -7     
  Branches      4395      4395           
=========================================
- Hits         13365     13358    -7     
Impacted Files Coverage Δ
packages/common/src/services/grid.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/gridState.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01158bb...58b04a0. Read the comment docs.

@ghiscoding ghiscoding merged commit 0b4d8b1 into master Aug 23, 2021
@ghiscoding ghiscoding deleted the bugfix/grid-state-grid-view branch August 23, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant