Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composite): calling Edit change shouldn't affect Mass-Update #448

Merged

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 24, 2021

  • fix an issue found that if we Edit a value (let say Title to "Task 1234") and then do a Mass Update on different field (say "% Complete" to 90%), the mass update was actually picking up the "Task 1234" from the previous edit even though it wasn't part of the Mass Update set of changes. The fix is to can simply clear the formValues object right after opening the modal window and before populating the form

- fix an issue found that if we Edit a value (let say Title to "Task 1234") and then do a Mass Update on different field (say "% Complete" to 90%), the mass update was actually picking up the "Task 1234" from the previous edit even though it wasn't part of the Mass Update. So we can simply clear the `formValues` object when opening the modal window and before populating the form
@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #448 (8f32dc1) into master (f867d19) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #448   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          219       219           
  Lines        13356     13355    -1     
  Branches      4395      4393    -2     
=========================================
- Hits         13356     13355    -1     
Impacted Files Coverage Δ
...-component/src/slick-composite-editor.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f867d19...8f32dc1. Read the comment docs.

@ghiscoding ghiscoding merged commit b0d9908 into master Aug 24, 2021
@ghiscoding ghiscoding deleted the bugfix/composite-previous-edit-affecting-mass-update branch August 24, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant