Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): providing usability override via grid option should work #557

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

ghiscoding
Copy link
Owner

- after merging the big controls/plugins PR #555 that rewrote all the plugins, I just found out this simple option got missed
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #557 (6446a10) into master (d15022b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #557   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          229       229           
  Lines        15754     15756    +2     
  Branches      5287      5288    +1     
=========================================
+ Hits         15754     15756    +2     
Impacted Files Coverage Δ
...kages/common/src/extensions/slickRowMoveManager.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15022b...6446a10. Read the comment docs.

@AnnetteZhang AnnetteZhang reopened this Nov 23, 2021
@AnnetteZhang AnnetteZhang merged commit 0c1b9e4 into master Nov 23, 2021
@AnnetteZhang AnnetteZhang deleted the bugfix/row-move-usability-defined branch November 23, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants