install udunits for macos check on r-devel

ghislainv · Jul 12, 2023 · e9de5ca · e9de5ca
1 parent 0f0560e
commit e9de5ca
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/check-standard.yaml b/.github/workflows/check-standard.yaml
@@ -41,6 +41,7 @@ jobs:
           brew install jags
           brew install gsl
           brew install gdal
+          brew install udunits
 
       - uses: r-lib/actions/setup-pandoc@v2
 

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -2,7 +2,7 @@ Package: jSDM
 Type: Package
 Title: Joint Species Distribution Models
 Version: 0.2.6
-Date: 2023-07-06
+Date: 2023-07-12
 Imports: Rcpp (>= 1.0.0), graphics, stats, coda, corrplot, stringi, MASS, parallel, doParallel, foreach, methods
 LinkingTo: Rcpp, RcppArmadillo, RcppGSL
 NeedsCompilation: yes

diff --git a/cran-comments.md b/cran-comments.md
@@ -2,10 +2,10 @@
 
 ## clang-UBSAN
 
-In test jSDM_poisson_log, Rcpp_jSDM_poisson_log_traits_rand_site_lv : 
+In jSDM_poisson_log tests, Rcpp_jSDM_poisson_log_traits_rand_site_lv : 
 runtime error: 3.11579e+10 is outside the range of representable values of type 'unsigned int'. 
 
-I've corrected this problem, I thought it was already done but I hadn't set up and fixed the random seed generator correctly, it's done now. 
+I have changed the type of the count data (Y) from unsigned int to unsigned long int in all C++ functions called by the jSDM_poisson_log function, in order to avoid this range problem and I've put back all the jSDM_poisson_log function tests that were deleted for the previous submission. 
 
 I have updated the date and removed commented lines of codes in the examples.