stats jsonp support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 11, 2012 01:45
|
Should this also allow the "jsonp" query variable? Maybe jsonp if set then callback if set, otherwise fallback to direct json? |
|
Inverse pull request for the above suggestion: https://github.com/pandemicsyn/brim/pull/1 |
Add jsonp as well as callback for jsonp query
|
Dangit, somehow I missed that you updated this. Probably collateral damage from my spam filters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny change to add jsonp support to stats i.e.
'http://127.0.0.1/stats?callback=hollaback'ps. brim rocks ☕ is on me on Monday