Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match by External IDs #31

Open
ghomasHudson opened this issue Jun 9, 2024 · 7 comments
Open

Match by External IDs #31

ghomasHudson opened this issue Jun 9, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@ghomasHudson
Copy link
Owner

Jellyfin items may have the IMDb or tmdb ids as metadata. We should search by these first for higher quality matching than name + year (which we can fallback to if no items are found with the id).

@ghomasHudson ghomasHudson added the enhancement New feature or request label Jun 9, 2024
@ghomasHudson ghomasHudson changed the title Search by External IDs Match by External IDs Jun 9, 2024
@BoHoliday
Copy link

This would be great since the plugin doesn't work properly for show-only lists. Currently, the plugin adds random episodes with the same name from other shows and sometimes even adds movies to the collection when it's supposed to only be searching for shows.

@ghomasHudson
Copy link
Owner Author

Added a partial implementation - imdb ids are now used as an additional filter. Searching via imdb_id doesnt seem to be supported by the jellyfin api so I'll have to work on the implementation.

@BoHoliday
Copy link

Added a partial implementation - imdb ids are now used as an additional filter. Searching via imdb_id doesnt seem to be supported by the jellyfin api so I'll have to work on the implementation.

This is great! Thanks so much for the work. Will this be implemented into the mdblist plugin as well?

@ghomasHudson
Copy link
Owner Author

is it not working already?

@BoHoliday
Copy link

BoHoliday commented Jun 16, 2024

The mdblist plugin is still adding single episodes or movies to the collection with the same name instead of the series, so I don't think it's using any imdb ids as a filter. I have series-only collections, and the script doesn't seem to know that it should only be adding series to the collection, not episodes or movies.

2024-06-16 02:38:05.420 | INFO     | utils.jellyfin:add_item_to_collection:133 - Added Presumed Innocent to collection
2024-06-16 02:38:09.639 | INFO     | utils.jellyfin:add_item_to_collection:133 - Added How Music Got Free to collection
2024-06-16 02:38:13.854 | INFO     | utils.jellyfin:add_item_to_collection:133 - Added Fantasmas to collection
2024-06-16 02:38:18.364 | INFO     | utils.jellyfin:add_item_to_collection:133 - Added Hitler and the Nazis: Evil on Trial to collection
2024-06-16 02:38:22.472 | INFO     | utils.jellyfin:add_item_to_collection:133 - Added The Acolyte to collection

Screenshot_4

@ghomasHudson
Copy link
Owner Author

The mdblist plugin is still adding single episodes or movies to the collection with the same name instead of the series, so I don't think it's using any imdb ids as a filter. I have series-only collections, and the script doesn't seem to know that it should only be adding series to the collection, not episodes or movies.

Well. There are 2 problems here. The existing implementation fell back to basic matches if there was no imdb_match. I've fixed this so if imdb_id is present, it will only match with imdb ids.

Secondly, the media type filters in jellyfin.py
need updating. I'll push some changes to hopefully fix these issues.

ghomasHudson added a commit that referenced this issue Jun 16, 2024
@BoHoliday
Copy link

The mdblist plugin is still adding single episodes or movies to the collection with the same name instead of the series, so I don't think it's using any imdb ids as a filter. I have series-only collections, and the script doesn't seem to know that it should only be adding series to the collection, not episodes or movies.

Well. There are 2 problems here. The existing implementation fell back to basic matches if there was no imdb_match. I've fixed this so if imdb_id is present, it will only match with imdb ids.

Secondly, the media type filters in jellyfin.py need updating. I'll push some changes to hopefully fix these issues.

Works flawlessly now, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants