Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible lull between waves of particles #122

Closed
Sky-Captain-13 opened this issue Dec 22, 2021 · 4 comments
Closed

Visible lull between waves of particles #122

Sky-Captain-13 opened this issue Dec 22, 2021 · 4 comments
Labels
bug Something isn't working confirmed

Comments

@Sky-Captain-13
Copy link

Expected Behavior

  • No lull between waves

Current Behavior

  • Lull between waves

image

Snow particles are being created on the left and as they move to the right, this creates a noticeable gap (especially at higher densities) before the next wave of particles are created.

Steps to Reproduce

  1. Add snow
  2. Set to max density
  3. Observe

Context

No response

Version

2.0.0

Foundry VTT Version

v9.238

Operating System

Windows 10

Browser / App

Native Electron App

Game System

dnd5e

Relevant Modules

n/a

@ghost91-
Copy link
Contributor

ghost91- commented Jan 9, 2022

Hey @Sky-Captain-13, I just released a new version (v2.2.0) which should fix this issue. Can you confirm the problem is gone now?

@Sky-Captain-13
Copy link
Author

Looks like it's fixed. Thanks! The left side still shows fewer of the snowflakes, but it's not as obvious as the lulls were.

@ghost91-
Copy link
Contributor

ghost91- commented Jan 10, 2022

Yeah, the reason for that is that when you don’t have a padding area (which you don’t seem to have in that scene), the spawn area of the particles is just all of the scene. That means on the left side, particles will spawn, but there are no particles that move into that area, they just move out of it, so there are always less particles in that area. I will probably improve the spawn areas of effects in the future so that the spawn area is a bit larger and effects look more uniform across their visible area. But it’s actually pretty difficult to get this exactly right while not wasting tu much resources by rendering stuff outside the visible area.

@Sky-Captain-13
Copy link
Author

Ah, yeah... I dislike having padding. So I set it to zero on every map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed
Projects
None yet
Development

No branches or pull requests

2 participants