Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #215 - Add package description #32

Merged
merged 4 commits into from Jun 23, 2023

Conversation

mfjurbala
Copy link
Member

This adds the ability to view or hide detailed package description to address Development Management item #41 ([Feature] Adding packages description window to Software Station#215).

Let me know of any changes or improvements.

Thanks

@mfjurbala mfjurbala requested a review from a team as a code owner June 19, 2023 03:03
Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I get when I run the code.

image

@ericbsd
Copy link
Member

ericbsd commented Jun 23, 2023

https://github.com/ghostbsd/ghostbsd-src/issues/215 was not well-defined, but my idea was to click on the package in the list and replace the interface.

By interface, I mean this:
image

That is why there is a back and forward button.

What you did is fine, but it will be replaced in the future.

@mfjurbala
Copy link
Member Author

mfjurbala commented Jun 23, 2023

I wondered why the back button was there but it didn't seem to do anything. This is what I am looking at and the tooltip on hover should show the description, I might have messed something up though. And no worries, if you want this in the meantime take it, if it would make more work just send it back, I can probably make that change pretty easily.

no_pkg
pkg

@ericbsd
Copy link
Member

ericbsd commented Jun 23, 2023

Oh wait, I think I install it from the wrong branch.

@ericbsd
Copy link
Member

ericbsd commented Jun 23, 2023

OK, that is working, not that I am the right branch.
image

@ericbsd
Copy link
Member

ericbsd commented Jun 23, 2023

That would be nice if all URLs could be clickable, but that could be done later.

Oh, before I get that merge, could you bump the version in the software-station file to 1.7

@ericbsd ericbsd self-requested a review June 23, 2023 11:26
@mfjurbala
Copy link
Member Author

Sure I'll do that maybe today or over the weekend.

@mfjurbala
Copy link
Member Author

The version is bumped and I had to mix a small fix to actually hide the description window.

I started to make the URL clickable but since software-station is running as root, it tries to open the browser as root which fails. I'm not sure if this is from me running sudo ./software-station to test or if it will always happen.

If it will always happen I wonder if we could or should make something like an administrator group that can run pkg commands.

Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericbsd ericbsd merged commit 772d7f2 into ghostbsd:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants