-
Notifications
You must be signed in to change notification settings - Fork 11
Moves the configuration classes to the sbt-codegen-plugin #181
Moves the configuration classes to the sbt-codegen-plugin #181
Conversation
Good idea, could you do the same for the mill plugin? |
Done! Didn't even realize there is a mill plugin :) |
Will still need to look into something, I'm not sure how to mark this PR as "work in progress" |
No problem, you can convert any opened PR into a draft: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request#converting-a-pull-request-to-a-draft |
Ok, the PR is now final. We've moved all the implicits to an |
@ghostbuster91 Just wanted to let you know that the PR is now ready for a review. Thank you in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks much cleaner now!
@ghostbuster91 You're welcome! Are you able to release a new version as well? |
Yes, I published it as 0.4.0 but the process failed because of artifacts conflict. I've just fixed the conflict and republished it as 0.4.1. Hopefully this time it will pass 🤞 |
The configuration classes have been moved to the sbt-codegen-plugin, so that they become accessible from the sbt settings. We've created a mapping from the sbt-codegen-plugin domain to the codegen-core, so that the codegen-core dependencies don't leak to the outside world.