Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Moves the configuration classes to the sbt-codegen-plugin #181

Merged
merged 3 commits into from
Jul 13, 2022
Merged

Moves the configuration classes to the sbt-codegen-plugin #181

merged 3 commits into from
Jul 13, 2022

Conversation

alycklama
Copy link
Contributor

The configuration classes have been moved to the sbt-codegen-plugin, so that they become accessible from the sbt settings. We've created a mapping from the sbt-codegen-plugin domain to the codegen-core, so that the codegen-core dependencies don't leak to the outside world.

@ghostbuster91
Copy link
Owner

Good idea, could you do the same for the mill plugin?

@alycklama
Copy link
Contributor Author

Good idea, could you do the same for the mill plugin?

Done! Didn't even realize there is a mill plugin :)

@alycklama
Copy link
Contributor Author

Will still need to look into something, I'm not sure how to mark this PR as "work in progress"

@alycklama
Copy link
Contributor Author

Ok, the PR is now final. We've moved all the implicits to an Implicits object, so that it doesn't clutter the OpenApiCodegenScalaModule anymore.

@alycklama
Copy link
Contributor Author

@ghostbuster91 Just wanted to let you know that the PR is now ready for a review. Thank you in advance!

Copy link
Owner

@ghostbuster91 ghostbuster91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks much cleaner now!

@ghostbuster91 ghostbuster91 merged commit f114495 into ghostbuster91:master Jul 13, 2022
@alycklama
Copy link
Contributor Author

@ghostbuster91 You're welcome! Are you able to release a new version as well?

@ghostbuster91
Copy link
Owner

Yes, I published it as 0.4.0 but the process failed because of artifacts conflict. I've just fixed the conflict and republished it as 0.4.1. Hopefully this time it will pass 🤞

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants