This repository has been archived by the owner on Oct 20, 2023. It is now read-only.
Adds support for custom date type #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alycklama
commented
Jul 13, 2022
| override def warn(msg: String): Unit = | ||
| println(s"Warning: $msg") | ||
| } | ||
| val StdOut: LogAdapter = (msg: String) => println(s"Warning: $msg") |
There was a problem hiding this comment.
Did some boyscouting here.
alycklama
commented
Jul 13, 2022
| @@ -124,7 +126,7 @@ object GeneratorTest extends TestSuite { | |||
|
|
|||
| def testNoCompile( | |||
| codeGenConfig: CodegenConfig = CodegenConfig() | |||
| )(implicit testPath: utest.framework.TestPath) = { | |||
| )(implicit testPath: utest.framework.TestPath): Unit = { | |||
There was a problem hiding this comment.
Gets rid of compiler warnings
alycklama
commented
Jul 13, 2022
| @@ -141,7 +143,7 @@ object GeneratorTest extends TestSuite { | |||
|
|
|||
| def test( | |||
| codeGenConfig: CodegenConfig = CodegenConfig() | |||
| )(implicit testPath: utest.framework.TestPath) = { | |||
| )(implicit testPath: utest.framework.TestPath): Unit = { | |||
There was a problem hiding this comment.
Gets rid of compiler warnings
|
Added a test for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would love to add a test for the custom data type, but it fails to find the specific implicit of
Encoder[org.joda.time.DateTime]. Which makes sense, I'm just wondering how I can bring it on scope in the test. Do you have any idea perhaps?