Variables in Subscription

[mitsutaka-takeda]

Hi. Thank you for the great library!

I started playing around with caliban and tried to use a variable in my subscription query like this one.

subscription OnEvent($topic: String!) {
    onEvent(topic: $topic) {
        name
    }
}

But caliban fails to execute query because it can not resolve the variable "$topic". I checked the WebSocket message and it contains variable definitions as expected.

{
  "id": "1",
  "type": "start",
  "payload": {
    "variables": {
      "topic": "mytopic"
    },
    "extensions": {},
    "operationName": "OnEvent",
    "query": "subscription OnEvent($topic: String!) { onEvent(topic: $topic) {name}}"
  }
}

The code for Http4sAdapter ignores the variables in payload is this intentional?

caliban/adapters/http4s/src/main/scala/caliban/Http4sAdapter.scala

Line 178 in dac5817

Task.whenCase(payload.downField("query").success.flatMap(_.value.asString)) {

When I change the line to something like this it can execute a query

val payload = msg.hcursor.downField("payload")
val id = msg.hcursor.downField("id").success.flatMap(_.value.asString).getOrElse("")
Task.whenCase(payload.as[GraphQLRequest]) {
   case Right(req) =>
       (for {
          result <- interpreter.execute(req.query.get, req.operationName, req.variables.getOrElse(Map.empty), req.extensions.getOrElse(Map.empty), skipValidation = skipValidation)

[ghostdogpr]

Hi! This is definitely not intentional, good catch 😄 Would you like to submit a PR to fix it? I’m guessing the problem might exist on all adapters that support WebSockets (that’d be http4s, Akka and uzhttp).