Move circe codecs to the core module #102
Conversation
rtimush
force-pushed
the
circe
branch
2 times, most recently
from
7cb4467
to
f9de6f2
Compare
|
|
||
| private object GraphQLRequestCirce { | ||
| import io.circe._ | ||
| import io.circe.derivation._ |
There was a problem hiding this comment.
Since we are using circe-derivation only for this single (and simple) type, how about deriving it manually and only depend on circe-core?
Because not everyone uses circe-derivation, some people use circe-generic, others circe-magnolia. That way we would keep the dependency minimal.
There was a problem hiding this comment.
I think codecs created by circe-derivation macros depend on the circe core only, so people won't need circe-derivation as a dependency. Although, to be on the safe side I can indeed implement it manually.
There was a problem hiding this comment.
Oh yeah, you must be right! All good then.
| @@ -103,7 +104,6 @@ lazy val http4s = project | |||
| "org.http4s" %% "http4s-circe" % "0.21.0-M5", | |||
| "org.http4s" %% "http4s-blaze-server" % "0.21.0-M5", | |||
| "io.circe" %% "circe-parser" % "0.12.3", | |||
| "io.circe" %% "circe-derivation" % "0.12.0-M7", | |||
There was a problem hiding this comment.
If we reduce the dependency to circe-core as I suggested in the other comment, this is good. But otherwise, I think we should keep that one so that people who use caliban-http4s don't need to add the dependency to circe-derivation themselves.
Circe codecs for
GraphQLRequestandGraphQLResponseare generally useful, so I moved them out of the http4s integration module. I also madeGraphQLRequestpublic.The pull request uses the trick described in https://blog.7mind.io/no-more-orphans.html — circe dependency is marked as optional, so you don't need circe to use caliban, but if you have it, the typeclass instances will be available without additional imports.