Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fully-qualified name for Vector in generated code #1254

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

cornerman
Copy link
Contributor

This is to avoid name-clashes with types from the graphql schema, i.e.,
if a type is called Vector.

Example:
enum ImageType {
Raster
Vector
}

This is to avoid name-clashes with types from the graphql schema, i.e.,
if a type is called Vector.

Example:
enum ImageType {
  Raster
  Vector
}
@cornerman
Copy link
Contributor Author

We encountered some edge cases with the line length - regarding the scalafmt config. Therefore, we had to add a line-break in one of the test cases. Does it make sense to pass the expected-code through the formatter as well?

@ghostdogpr
Copy link
Owner

We encountered some edge cases with the line length - regarding the scalafmt config. Therefore, we had to add a line-break in one of the test cases. Does it make sense to pass the expected-code through the formatter as well?

Hmm, I think that's fine as it is. Might be difficult to find differences if we call the formatter on the expected code.

@ghostdogpr ghostdogpr merged commit f2f2fd1 into ghostdogpr:master Jan 12, 2022
@cornerman cornerman deleted the fqn-vector branch January 12, 2022 13:10
Fluxx pushed a commit to Fluxx/caliban that referenced this pull request Jan 27, 2022
This is to avoid name-clashes with types from the graphql schema, i.e.,
if a type is called Vector.

Example:
enum ImageType {
  Raster
  Vector
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants