add support for graphql-transport-ws #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @paulpdaniels, What are these new variants? Where can I read about them, please? |
https://github.com/apollographql/subscriptions-transport-ws/blob/master/PROTOCOL.md was deprecated in favor of https://github.com/enisdenjo/graphql-ws/blob/master/PROTOCOL.md |
ghostdogpr
reviewed
May 3, 2022
interop/tapir/src/main/scala/caliban/interop/tapir/TapirAdapter.scala
Outdated
Show resolved
Hide resolved
ghostdogpr
reviewed
May 3, 2022
interop/tapir/src/test/scala/caliban/interop/tapir/ws/ProtocolSpec.scala
Outdated
Show resolved
Hide resolved
paulpdaniels
force-pushed
the
graphql-transport-ws
branch
from
4cf0f6b
to
99ca015
Compare
|
@frekw @ghostdogpr I made some significant changes since the last review, namely I refactored the pipeline logic so that it could more seamlessly handle detecting the protocol, and I had to rewire the websocket handler because the |
|
Only the akka and play adapters seems to fail 🤔 |
paulpdaniels
force-pushed
the
graphql-transport-ws
branch
3 times, most recently
from
c0f37d8
to
662506b
Compare
|
I'm traveling this weekend and Monday but I'll take a look in the coming week! |
paulpdaniels
force-pushed
the
graphql-transport-ws
branch
from
662506b
to
4be72b4
Compare
ghostdogpr
reviewed
Jun 4, 2022
interop/tapir/src/test/scala/caliban/interop/tapir/TestService.scala
Outdated
Show resolved
Hide resolved
adapters/akka-http/src/test/scala/caliban/AkkaHttpAdapterSpec.scala
Outdated
Show resolved
Hide resolved
interop/tapir/src/main/scala/caliban/interop/tapir/TapirAdapter.scala
Outdated
Show resolved
Hide resolved
interop/tapir/src/test/scala/caliban/interop/tapir/TapirAdapterSpec.scala
Outdated
Show resolved
Hide resolved
interop/tapir/src/main/scala/caliban/interop/tapir/ws/Protocol.scala
Outdated
Show resolved
Hide resolved
|
@ghostdogpr I just tried with the zio-http/akka and it works (it supports both formats simultaneously!). Http4s had what seems like a small compatibilty issue (sent back a null payload when it shouldn't), so I patched that. |
ghostdogpr
approved these changes
Jun 12, 2022
ghostdogpr
pushed a commit
that referenced
this pull request
Jun 20, 2022
* upgrade zio-config to 2.0.0 (#1367) * Update http4s-blaze-server to 0.23.12 (#1368) * Properly validate floating point numbers on input (#1370) * Escape quotes in description strings (#1372) Escape " with \" in normally quoted strings and """ with \""" in triple-quoted strings. https://spec.graphql.org/October2021/#sec-String-Value * Improve persisted query performance by caching the document (#1371) * improve persisted query performance by caching the document instead of the unparsed string. * address comments * Escape special characters in normally quoted strings (#1373) * Correct field types for interface fields on union (#1375) Ensure that when an interface fragment is used on a union that the fields its selected have the correct type instead of always being `String`. * Coerce non-null values into lists of size one (#1376) * Coerce non-null values into lists of size one As per the specification, if a value passed as an input to a list type is not a list and is not null then it should be coerced into a list of size one. * Make work on Scala 3 * Client auto-gen Option conflict (#1377) * have ClientWriter print scala.Option instead of Option * Fix replace case where Option may appear multiple times * Add test for various returns of GQL Option and scala.Option * run fmt * update ClientWriterViewSpec * SchemaWrite should also print scala.Option instead of Option * add a scripted test with a schema containing type Option * flatten scripted compile tests * make helper method for safe Option string replacement * add support for graphql-transport-ws (#1354) * add support for graphql-transport-ws * Set api mappings for ZIO (#1381) Co-authored-by: Lordie <levimanga@gmail.com> Co-authored-by: Scala Steward <43047562+scala-steward@users.noreply.github.com> Co-authored-by: Kevin Mooney <moonkev@users.noreply.github.com> Co-authored-by: Johannes Eriksson <johannes@stepzen.com> Co-authored-by: Paul Daniels <paulpdaniels@gmail.com> Co-authored-by: Mark Rudolph <mark@k8ty.app>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the new graphql subscription variant. Splits the handling of the protocol into a separate type so that it can be implemented in a single place rather than in the adapters + zio-http.
There is probably even more refactoring that can be done here to get a smaller LOC profile, but I got as far as the weekend would allow so figured this would be a good checkin that we can continue to enhance.