Fix cache poisoning #1362
Merged
Fix cache poisoning #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
May 19, 2022
| @@ -6,6 +6,9 @@ import caliban.wrappers.Wrapper.OverallWrapper | |||
| import caliban.{ CalibanError, GraphQLRequest, GraphQLResponse, InputValue } | |||
| import zio.{ Has, Layer, Ref, UIO, ZIO } | |||
|
|
|||
| import java.nio.charset.StandardCharsets | |||
| import javax.xml.bind.DatatypeConverter | |||
There was a problem hiding this comment.
Hmm it doesn't find this in the CI, is that specific to some JVMs?
There was a problem hiding this comment.
Fixed, I thought javax.xml would be safe but it wasn't too hard to write my own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a potential security vulnerability in the ApolloPersistedQuery wrapper that allowed for cache poisoning.