Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to hide unsafe call with akka-http wrapper #181

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Allow to hide unsafe call with akka-http wrapper #181

merged 1 commit into from
Jan 28, 2020

Conversation

loicdescotte
Copy link
Contributor

Very small PR to allow to hide unsafe call with akka-http wrapper

@ghostdogpr
Copy link
Owner

You need to run fmt in sbt for linting.

About the naming, how about makeHttpServiceM? Like in ZIO, a lot of functions have an M (for Monadic) variant that takes an effect instead of a simple value.

@loicdescotte
Copy link
Contributor Author

Done + rebased the history :)

ghostdogpr
ghostdogpr approved these changes Jan 28, 2020
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghostdogpr ghostdogpr merged commit f017a20 into ghostdogpr:master Jan 28, 2020
@loicdescotte loicdescotte deleted the akka_hide_unsafe branch January 28, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loicdescotte @ghostdogpr