Add Mixed query execution mode #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how common this is, but in some of our schemas we don't need use DataSources for some of the top-level query fields as they're not reused elsewhere in the schema, and therefor we don't need to make use of caching / batching. The downside is that unless we wrap them in DataSources, they won't be executed in parallel if the client requests multiple top-level fields.
With this change, we provide a
QueryExecution.Mixedmode, where top-level fields are guaranteed to be executed in parallel (regardless if backed by a DataSource), and nested fields are executed in batched mode