Add federation #314
Merged
Add federation #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpdaniels
commented
Apr 7, 2020
paulpdaniels
force-pushed
the
federation-wip
branch
from
8166383
to
9cace27
Compare
paulpdaniels
force-pushed
the
federation-wip
branch
2 times, most recently
from
f4eaa94
to
a01dc0a
Compare
paulpdaniels
force-pushed
the
federation-wip
branch
from
a01dc0a
to
9aefc0e
Compare
ghostdogpr
reviewed
Apr 11, 2020
|
@ghostdogpr comments addressed! |
ghostdogpr
reviewed
Apr 12, 2020
vuepress/docs/docs/federation.md
Outdated
| To use, add the following line to your `build.sbt` file: | ||
|
|
||
| ``` | ||
| libraryDependencies += "com.github.ghostdogpr" %% "caliban-federation" % "0.7.3" |
There was a problem hiding this comment.
Can you make it 0.7.4? So that next time I release, a find & replace will find it 😄
federation/src/main/scala/caliban/federation/EntityResolver.scala
Outdated
Show resolved
Hide resolved
paulpdaniels
force-pushed
the
federation-wip
branch
from
bbabbe9
to
b6ae340
Compare
|
All good, thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds federation to caliban. ATM it is still a WIP but I wanted to open the PR early to get feedback on the approach.
More info on the federation spec can be found here.
There are a couple pieces that are still missing in no particular order:
Federated schema validation(Handled by the gateway)Error handling(Same as normal graphql)EntityResolversmore ergonomic (automatic generation?)