Add schema directives validation #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
reviewed
Apr 18, 2020
| val fieldErrorContext: String => String = fieldName => s"Field '$fieldName' of $typeErrorContext" | ||
| for { | ||
| _ <- validateDirectives[__Type](t, _.directives, typeErrorContext) | ||
| _ <- IO.foreach_(t.fields(__DeprecatedArgs(Some(true))).getOrElse(List.empty[__Field]))(f => |
There was a problem hiding this comment.
There can also be directives in __Type.inputFields and __Field.args: both contain __InputValue which has directives.
There was a problem hiding this comment.
I haven't seen those, added!
ghostdogpr
reviewed
Apr 19, 2020
| } | ||
|
|
||
| def validateDirectives[T]( | ||
| t: T, |
There was a problem hiding this comment.
You pass T and T => Option[List[Directive]], why not just pass Option[List[Directive]]? Then you won't need the type parameter anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the schema validation rules for directives posted in #232, I've implemented the 3 and 4.1 rules in this PR.
I think that due to the type model, it isn't necessary to check the rest of the rules, but I'm no pretty sure, am I missing something?