Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make query optional in Http Get methods #400

Merged
merged 1 commit into from
May 19, 2020
Merged

Make query optional in Http Get methods #400

merged 1 commit into from
May 19, 2020

Conversation

javimartinez
Copy link
Contributor

  • AkkaHttp adapter
  • Finch adapter

@javimartinez
Make query optional in Http Get methods
44b93e5 
* AkkaHttp adapter
* Finch adapter
ghostdogpr
ghostdogpr approved these changes May 19, 2020
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Totally forgot the Finch case.

@ghostdogpr ghostdogpr merged commit f07b281 into ghostdogpr:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javimartinez @ghostdogpr