Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multipart request for play #500

Merged
merged 20 commits into from
Dec 4, 2020
Merged

add multipart request for play #500

merged 20 commits into from
Dec 4, 2020

Conversation

igorfialko
Copy link
Contributor

@igorfialko
add multipart request for play
6ac44d7
@igorfialko
Merge branch 'master' of https://github.com/ghostdogpr/caliban into g…
0c5ea3a 
…hostdogpr-master

# Conflicts:
#	adapters/play/src/main/scala/caliban/PlayAdapter.scala
#	adapters/play/src/main/scala/caliban/PlayRouter.scala
@igorfialko
Merge branch 'ghostdogpr-master' into 451
2434755
@igorfialko
remove unnecessary test
4863b1e
@igorfialko
add missing layers
bf29b66
paulpdaniels
paulpdaniels reviewed Jul 14, 2020
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
@paulpdaniels
Copy link
Collaborator

@igorfialko are you planning to continue work on this?

@igorfialko
Copy link
Contributor Author

@paulpdaniels Looks like the only thing left for play is the usage of other testing library. Is that correct?

@paulpdaniels
Copy link
Collaborator

That was all I had yes @igorfialko

@igorfialko
Copy link
Contributor Author

@paulpdaniels Ok, I'll try to squeeze it this week. Maybe further splitting #451 by framework would make sense?

@paulpdaniels paulpdaniels mentioned this pull request Oct 13, 2020
Closed
5 tasks
paulpdaniels
paulpdaniels reviewed Nov 1, 2020
View reviewed changes
adapters/play/src/main/scala/caliban/Uploads.scala Outdated Show resolved Hide resolved
adapters/play/src/main/scala/caliban/Uploads.scala Outdated Show resolved Hide resolved
adapters/play/src/main/scala/caliban/Uploads.scala Outdated Show resolved Hide resolved
adapters/play/src/test/scala/caliban/AdapterSpec.scala Show resolved Hide resolved
adapters/play/src/test/scala/caliban/AdapterSpec.scala Outdated Show resolved Hide resolved
adapters/play/src/test/scala/caliban/AdapterSpec.scala Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
paulpdaniels
paulpdaniels approved these changes Nov 5, 2020
View reviewed changes
Copy link
Collaborator

@paulpdaniels paulpdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits from me otherwise LGTM

@igorfialko igorfialko closed this Nov 8, 2020
@igorfialko igorfialko reopened this Nov 8, 2020
ghostdogpr
ghostdogpr reviewed Nov 9, 2020
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a tiny remark on dependencies that can be simplified. Also I wonder if there's an easy way to make the dependency to Blocking and Random optional without duplicating code? If not this is fine.

build.sbt Outdated Show resolved Hide resolved
@paulpdaniels
Copy link
Collaborator

I do recall there is a +++ operator that lets you select between a provided left or right environment, but I don't know if that would apply here because we actually require the Runtime upfront so we wouldn't be able to switch it out.

ghostdogpr
ghostdogpr approved these changes Dec 4, 2020
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!

@ghostdogpr ghostdogpr merged commit fb7b2c8 into ghostdogpr:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulpdaniels paulpdaniels paulpdaniels approved these changes

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@igorfialko @paulpdaniels @ghostdogpr