Add location and path info to error message #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's one test that needs to be updated, otherwise very nice 👍 |
paulpdaniels
force-pushed
the
add-meta-error-metadata
branch
from
666f3f3
to
d96e6da
Compare
paulpdaniels
force-pushed
the
add-meta-error-metadata
branch
from
d96e6da
to
54ca73c
Compare
ghostdogpr
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the location and path info to an
ExecutionErrorthat is thrown during field resolution. I'm not sure if we want to have some sort of "opt-out" mechanism in case users don't want this behavior, but in general it is the minimum we should have when showing errors, since it allows the client to piece it back together with the original query.