#420. add routing (application/graphql) in finch. #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
approved these changes
Jul 28, 2020
|
Oh, I didn't notice before I merged but the CI didn't run, not sure why 🤔 I will fix the linting issue on master. |
|
Thank you, approve. |
|
It's not your fault, normally the CI is supposed to run when you open a PR but it didn't work 🤔 To format the code you can simply run |
|
Thanks a lot, I understand to use scala fmt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement routing POST request in the case of finch. for #420.
This PR is my first challenge for function of caliban, please tell me bad point.