Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for field metadata optimizations. #646

Merged
merged 3 commits into from
Nov 22, 2020
Merged

Add support for field metadata optimizations. #646

merged 3 commits into from
Nov 22, 2020

Conversation

jweaver-personal
Copy link
Contributor

Add support for field metadata optimizations by allowing for

Field => A
Field => (A => B)

functions on the schema model.

Addresses issue Expose selection information in resolve #632

ghostdogpr
ghostdogpr reviewed Nov 22, 2020
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just left a few comments for cleaning it up. You can solve the CI failure by running fmt in sbt to format the code.

core/src/main/scala/caliban/schema/Schema.scala Outdated Show resolved Hide resolved
core/src/test/scala/caliban/execution/ExecutionSpec.scala Outdated Show resolved Hide resolved
core/src/test/scala/caliban/execution/ExecutionSpec.scala Outdated Show resolved Hide resolved
vuepress/docs/docs/optimization.md Show resolved Hide resolved
vuepress/docs/docs/optimization.md Outdated Show resolved Hide resolved
ghostdogpr
ghostdogpr approved these changes Nov 22, 2020
View reviewed changes
Copy link
Owner

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@ghostdogpr ghostdogpr merged commit 7f453ea into ghostdogpr:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose selection information in resolve
2 participants
@jweaver-personal @ghostdogpr