Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scriptlet params edge case fix #3558

Merged
merged 3 commits into from
Oct 28, 2023
Merged

Scriptlet params edge case fix #3558

merged 3 commits into from
Oct 28, 2023

Conversation

chrmod
Copy link
Member

@chrmod chrmod commented Oct 27, 2023

No description provided.

@chrmod chrmod changed the title Example of breaking scriptlet Scriptlet params edge case fix Oct 27, 2023
@chrmod chrmod force-pushed the complex-scriptlet-param-fix branch from 63f28a5 to f2aa9ad Compare October 27, 2023 14:53
@chrmod chrmod force-pushed the complex-scriptlet-param-fix branch from f2aa9ad to 636437b Compare October 27, 2023 14:53
@chrmod chrmod marked this pull request as ready for review October 27, 2023 16:20
@chrmod chrmod requested a review from remusao as a code owner October 27, 2023 16:20
@philipp-classen
Copy link
Member

Intended to capture the cases that we are aware of. For instance, for to parse xml-parse rules like this here:

www.amazon.co.jp,www.amazon.com,www.amazon.de##+js(xml-prune, xpath(//*[name()="Period"][.//*[@value="Ad"]] | //*[name()="Period"]/@start), [value="Ad"], .mpd)

@chrmod chrmod force-pushed the complex-scriptlet-param-fix branch from 898940f to 103f5e9 Compare October 28, 2023 07:48
@chrmod chrmod merged commit 46cf8ea into master Oct 28, 2023
3 checks passed
@chrmod chrmod deleted the complex-scriptlet-param-fix branch October 28, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants