Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modifier replacer for NetworkFilter.toString #3699

Merged
merged 5 commits into from
Jan 10, 2024
Merged

feat: modifier replacer for NetworkFilter.toString #3699

merged 5 commits into from
Jan 10, 2024

Commits on Jan 9, 2024

  1. feat: modifier replacer for NetworkFilter.toString 

    To make minimal performance impact on current codes using adblocker library, I chose to use Array.prototype.map function instead of putting `if` statements or using empty proxying function: `(str: text) => str` as default value.

refs ghostery#3693
    @seia-soto
    seia-soto committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    370f368 View commit details
    Browse the repository at this point in the history

  2. chore: fix types 

    use `as const` keyword
    @seia-soto
    seia-soto committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    5a86a0b View commit details
    Browse the repository at this point in the history

  3. chore(test): fix test output 

    refs ghostery#3681
    @seia-soto
    seia-soto committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    f82f0a1 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Merge remote-tracking branch 'origin/master' into add-filter-tostring… 

    …-modifier-mapping-function
    @seia-soto
    seia-soto committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    53ba276 View commit details
    Browse the repository at this point in the history

  2. fix(test): test expectation to match latest commit 

    refs ghostery#3681
    @seia-soto
    seia-soto committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    bb4dd02 View commit details
    Browse the repository at this point in the history