Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build system: fix yarn warnings for @types/node #3984

Merged
merged 1 commit into from
May 29, 2024
Merged

Build system: fix yarn warnings for @types/node #3984

merged 1 commit into from
May 29, 2024

Conversation

chrmod
Copy link
Member

@chrmod chrmod commented May 29, 2024

yarn install was showing such warnings

➤ YN0002: │ @cliqz/adblocker-puppeteer-example@workspace:packages/adblocker-puppeteer-example doesn't provide @types/node (p0d389), requested by ts-node.
➤ YN0002: │ @cliqz/adblocker-puppeteer@workspace:packages/adblocker-puppeteer [01506] doesn't provide @types/node (p21284), requested by ts-node.
➤ YN0002: │ @cliqz/adblocker-puppeteer@workspace:packages/adblocker-puppeteer doesn't provide @types/node (pea7c0), requested by ts-node.
➤ YN0002: │ @cliqz/adblocker-webextension-cosmetics@workspace:packages/adblocker-webextension-cosmetics doesn't provide @types/node (pdb198), requested by ts-node.
➤ YN0002: │ @cliqz/adblocker-webextension@workspace:packages/adblocker-webextension doesn't provide @types/node (p6be02), requested by ts-node.

remedy was to add @types/node as dev dependency to listed packages.

@chrmod chrmod requested a review from remusao as a code owner May 29, 2024 07:13
@chrmod chrmod added the PR: Internal 🏠 Changes only affect internals label May 29, 2024
@chrmod chrmod merged commit d415b44 into master May 29, 2024
3 checks passed
@chrmod chrmod deleted the fixing-yarn-warnings branch May 29, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remusao remusao remusao approved these changes

Assignees
No one assigned
Labels
PR: Internal 🏠 Changes only affect internals
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrmod @remusao