Upgrade webextension-polyfill #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That should allows us to remove the patch ghostery/ghostery-extension#830 refs ghostery/ghostery-extension#806
philipp-classen
added a commit
to philipp-classen/common
that referenced
this pull request
Oct 7, 2022
This reverts commit d05c15b. Actually, not a good idea. Upgrading introduces other problems, especially the use of newer syntax like that here creates issues for our webpack setup: if (!globalThis.chrome?.runtime?.id) { throw new Error("This script should only be loaded in a browser extension."); } Since there is no pressing reason to upgrade, rolling it back here. It would otherwise break the ghostery-extension when it upgrades "common". refs ghostery#62
philipp-classen
added a commit
that referenced
this pull request
Oct 7, 2022
This reverts commit d05c15b. Actually, not a good idea. Upgrading introduces other problems, especially the use of newer syntax like that here creates issues for our webpack setup: if (!globalThis.chrome?.runtime?.id) { throw new Error("This script should only be loaded in a browser extension."); } Since there is no pressing reason to upgrade, rolling it back here. It would otherwise break the ghostery-extension when it upgrades "common". refs #62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That might allow us to remove the patch ghostery/ghostery-extension#830
refs ghostery/ghostery-extension#806