Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace license list generator #1455

Merged
merged 2 commits into from Feb 2, 2024
Merged

Replace license list generator #1455

merged 2 commits into from Feb 2, 2024

Conversation

chrmod
Copy link
Member

@chrmod chrmod commented Feb 2, 2024

the license-checker was not supported and multiple of its dependencies have been deprecated

"build.dev": "webpack --mode development --progress",
"build": "webpack --mode production --progress",
"build.prod": "npm run build",
"build.watch": "webpack --mode development --progress --watch",
"licenses": "node ../tools/licenses.js",
"licenses": "license-report --config=../license-report-config.json > dist/licenses.html",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the license-report-config.json file? Is it generated by the npm package? Shouldn't be in the gitignore then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to push it

@chrmod chrmod requested a review from smalluban February 2, 2024 15:22
@chrmod chrmod merged commit 0e346ee into main Feb 2, 2024
2 checks passed
@chrmod chrmod deleted the remove-license-checker branch February 2, 2024 19:14
@smalluban smalluban mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants