Create fallback tracker in the trackerdb utility #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
smalluban
commented
May 7, 2024
smalluban
commented
- Passes through requests without exception where category should not be blocked
- Moves fallback tracker for unidentified trackers to trackerdb - There is a bug when you add exception to the request, which is not in the trackerdb - then the metadata must be created there, as from now the metadata is returned (but without required info)
chrmod
reviewed
May 7, 2024
|
|
||
| tracker = { | ||
| id: request.domain, | ||
| name: request.domain, |
There was a problem hiding this comment.
should those be domain or hostname in case of IP addresses?
There was a problem hiding this comment.
I'll add fallback in the domain property of the ExtendedRequest
chrmod
approved these changes
May 7, 2024
smalluban
added a commit
that referenced
this pull request
May 10, 2024
* Update translations * Update hybrids and remove store set fix * Fix copy & translations * Panel fixes * Don't inject TrackerDB consmetic filters fix https://github.com/orgs/ghostery/projects/42/views/1?pane=issue&itemId=61454006 They were blocking from Consent Management category which renders Never-Consent useless. * Fix protection status button height * Create fallback tracker in the trackerdb utility (#1580) * Create fallback tracker in the trackerdb utility * Add fallback to `request.domain` * Fix missing translations * Update translations * Fix request hostname used internally by the adblocker engine * Update translations * Fix tracker matching for updating stats * Fix panel status toggle click callback * Fix Firefox tracker details url copy layout * Fix polish translations * Exceptions for first party --------- Co-authored-by: Dominik Lubański <dominik.lubanski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.