Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved C2P Script Injection #528

Merged
merged 11 commits into from Apr 28, 2020
Merged

Improved C2P Script Injection #528

merged 11 commits into from Apr 28, 2020

Conversation

@christophertino
Copy link
Member

@christophertino christophertino commented Apr 21, 2020

Fixes an issue where the click_to_play.js content script can be injected N times per page, where N equals the number of matched C2P elements. This PR tracks C2P load status per tab and queues C2P messages until the content script has loaded.

@christophertino christophertino added this to the 8.5.0 milestone Apr 21, 2020
@christophertino christophertino requested a review from jsignanini Apr 21, 2020
@christophertino christophertino requested review from Eden12345, wlycdgr, zarembsky and ghostery/ghostery as code owners Apr 21, 2020
@christophertino christophertino changed the base branch from master to develop Apr 21, 2020
…TabInfo. Updated unit tests
@christophertino christophertino merged commit 1f1c85e into develop Apr 28, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-2017 branch Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants