Improved C2P Script Injection #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophertino
requested review from
Eden12345,
wlycdgr and
zarembsky
as code owners
…TabInfo. Updated unit tests
jsignanini
approved these changes
Apr 28, 2020
chrmod
pushed a commit
that referenced
this pull request
Jul 28, 2022
* better handling of C2P script injection by tab * fixing bugs in c2p social icons. Pass entire queue to content script after injection * set c2p queue as hashmap to prevent duplicates * remove early return when iterating through social icons * add unit testing for src/utils/click2play * add c2p data to queue when inject status is 'none'. Proper use of setTabInfo. Updated unit tests * more code coverage * add unit tests for buildRedirectC2P() * add units tests for allowAllwaysC2P
chrmod
pushed a commit
that referenced
this pull request
Jul 29, 2022
* better handling of C2P script injection by tab * fixing bugs in c2p social icons. Pass entire queue to content script after injection * set c2p queue as hashmap to prevent duplicates * remove early return when iterating through social icons * add unit testing for src/utils/click2play * add c2p data to queue when inject status is 'none'. Proper use of setTabInfo. Updated unit tests * more code coverage * add unit tests for buildRedirectC2P() * add units tests for allowAllwaysC2P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the click_to_play.js content script can be injected N times per page, where N equals the number of matched C2P elements. This PR tracks C2P load status per tab and queues C2P messages until the content script has loaded.