Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Enable automatic updates" setting propagates to antitracking and adblocker #646

Merged
merged 7 commits into from
Jan 6, 2021

Conversation

sammacbeth
Copy link
Contributor

Fixes #561

Allows all remote resource fetches from modules in ghostery-common to be disabled.

  • Disabling "Enable automatic updates from the Ghostery tracker library" will also disable updates to antitracking and adblocker lists.
  • Disabling humanweb will disable the hpnv2 module entirely, preventing fetches to its config endpoint.

To test, check network calls from the extension, and reload the extension to see startup calls:

  • When automatic updates are enabled, there will be a call to https://cdn.ghostery.com/antitracking/whitelist/2/update.json.gz. When disabled, this call will not happen.
  • When humanweb is enabled, there will be a call to https://api.ghostery.net/api/v1/config on start, and subsequent calls to https://collector-hpn.ghostery.net/config. When disabled, these calls will not happen.

@christophertino christophertino added this to the 8.5.5 milestone Dec 18, 2020
@christophertino christophertino merged commit 4ae087f into ghostery:develop Jan 6, 2021
chrmod pushed a commit that referenced this pull request Jul 28, 2022
…locker (#646)

* Sync antitracking networkFetchEnabled setting with enable_autoupdate.

* Disable hpnv2 when humanweb is disabled.

* Disable anolysis on non-android devices

* Fix lint error

* Sync adblocker fetch enabled state with enable_autoupdate

* Bump ghostery-common to 1.2.0

Co-authored-by: Christopher Tino <4699516+christophertino@users.noreply.github.com>
chrmod pushed a commit that referenced this pull request Jul 29, 2022
…locker (#646)

* Sync antitracking networkFetchEnabled setting with enable_autoupdate.

* Disable hpnv2 when humanweb is disabled.

* Disable anolysis on non-android devices

* Fix lint error

* Sync adblocker fetch enabled state with enable_autoupdate

* Bump ghostery-common to 1.2.0

Co-authored-by: Christopher Tino <4699516+christophertino@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

why can't ghostery simply work offline and only optionally connect online
2 participants