Fix site breakage related to the Tracker-Tally CSS #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that interacts with the injected css code. A recent example is "https://mycovidrecord.health.nz/", which fails with: Uncaught DOMException: CSSStyleSheet.cssRules getter: Not allowed to access cross-origin stylesheet These older examples could be duplicates as well: * niklasvh/html2canvas#2197 * https://stackoverflow.com/a/62475347/783510 We can delay the css injection to "document_end" instead of "document_start". It may still happen, but it should make it less likely.
|
Also, disabling the feature for new installations (users can enable it through the UI: settings -> Tracker Tally). |
chrmod
previously approved these changes
Nov 19, 2021
|
This is still happening for our webapp. We use rails + webpacker. |
|
@varun-raj We will push a release soon (most likely tomorrow). Apology for the delay, but once it is live, it should fix the problems. |
chrmod
pushed a commit
that referenced
this pull request
Jul 28, 2022
* On Firefox, the Tracker-Tally can break sites that run JavaScript that interacts with the injected css code. A recent example is "https://mycovidrecord.health.nz/", which fails with: Uncaught DOMException: CSSStyleSheet.cssRules getter: Not allowed to access cross-origin stylesheet These older examples could be duplicates as well: * niklasvh/html2canvas#2197 * https://stackoverflow.com/a/62475347/783510 We can delay the css injection to "document_end" instead of "document_start". It may still happen, but it should make it less likely. * Make the Tracker-Tally opt-in for new installations. * Remove dead variable
chrmod
pushed a commit
that referenced
this pull request
Jul 29, 2022
* On Firefox, the Tracker-Tally can break sites that run JavaScript that interacts with the injected css code. A recent example is "https://mycovidrecord.health.nz/", which fails with: Uncaught DOMException: CSSStyleSheet.cssRules getter: Not allowed to access cross-origin stylesheet These older examples could be duplicates as well: * niklasvh/html2canvas#2197 * https://stackoverflow.com/a/62475347/783510 We can delay the css injection to "document_end" instead of "document_start". It may still happen, but it should make it less likely. * Make the Tracker-Tally opt-in for new installations. * Remove dead variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tracker-Tally can break sites that run JavaScript that interacts with the injected css code. A recent example is
"https://mycovidrecord.health.nz/", which fails with:
These older examples could be duplicates as well:
We can delay the css injection to "document_end" instead of "document_start". It may still happen, but it should make it
less likely with little downsides. In the concrete example, I can no longer reproduce with the change.