Smart Blocking: Allow blocking of first party tracking #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrmod
force-pushed
the
block-first-party-tracking
branch
from
9655869
to
3e87e8c
Compare
chrmod
changed the title
philipp-classen
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Merging for now, as the change makes sense. It has an unintended side-effect of disabling the later steps of the community-based adblocking (the removed code path did not set eventMutable.ghosteryWhitelisted = true).
As the former behavior is more accidental, merging and finding a proper fix for the latter (it is an independent issue) makes sense IMHO.
chrmod
added a commit
that referenced
this pull request
Jul 28, 2022
chrmod
added a commit
that referenced
this pull request
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to deal with cname cloaking we have to be able to block first party trackers. That way we can block Google Beacons.