Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new currency and stocks from another country #386

Closed
eHonnef opened this issue Sep 21, 2021 · 4 comments · Fixed by #387
Closed

Add new currency and stocks from another country #386

eHonnef opened this issue Sep 21, 2021 · 4 comments · Fixed by #387
Assignees

Comments

@eHonnef
Copy link

eHonnef commented Sep 21, 2021

I really enjoyed this project, it's simple and very intuitive and the best one is that it is open source and self hosted :D

But I can't use to manage the portfolio on my country (Brazil), I don't know the technical details, but I think it'll not be so difficult to add the B3 (Bovespa and BMF) and BRL currency to the project, the stock info already is at the yahoo financial (for example PETR4).

Thanks and keep the good work :D

@dtslvr
Copy link
Member

dtslvr commented Sep 21, 2021

Thanks a lot for your feedback @eHonnef.

At the moment, Ghostfol.io only supports the following currencies: CHF, EUR, GBP and USD.

To support unlimited currencies, there is some rework needed:

  1. Migrate the database schema from enum to string
  2. Adapt the code (enum to string)
  3. Dynamically identify the currencies needed (user accounts, accounts, transactions)
  4. Allow to set the base currency in My Ghostfolio

This issue is related to #286 (symbol in CAD) and I have just started to work on it.

@dtslvr dtslvr self-assigned this Sep 21, 2021
@eHonnef
Copy link
Author

eHonnef commented Sep 21, 2021

Thanks, I'm looking forward to use it :D

@dtslvr dtslvr linked a pull request Sep 21, 2021 that will close this issue
@dtslvr
Copy link
Member

dtslvr commented Sep 21, 2021

Thanks, I'm looking forward to use it :D

I have started working on it here #387. It's still a draft and needs some more refinements.

@dtslvr
Copy link
Member

dtslvr commented Sep 24, 2021

I have merged this feature now. Do you have a chance to check it and give feedback @eHonnef?

Do not forget to regenerate the typings (database:generate-typings) and apply the data migration (yarn prisma migrate deploy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants