Feature/support unlimited currencies #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 21, 2021
|
Current limitation
|
vzickner
reviewed
Sep 23, 2021
| this.initialize(); | ||
| } | ||
|
|
||
| public getCurrencies() { | ||
| return this.currencies?.length > 0 ? this.currencies : [baseCurrency]; |
There was a problem hiding this comment.
base currency might not be part of this.currencies, or? I just try to understand why the ? : is required
There was a problem hiding this comment.
If the instance has no transactions and no users, it could be problematic if there is no currency at all
dtslvr
force-pushed
the
feature/support-unlimited-currencies
branch
from
794349c
to
4bc98b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.