-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solve problem with deleting filtered activities #3394
Solve problem with deleting filtered activities #3394
Conversation
…er applied it deletes all the activites and not the ones that are filtered \
Could you please resolve the conflicts before the code review? Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, I have added a few comments
apps/client/src/app/pages/portfolio/activities/activities-page.component.ts
Outdated
Show resolved
Hide resolved
Applied what your said in the comments but now you can't delete orders using filters due to #3389 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied what your said in the comments but now you can't delete orders using filters due to #3389
You can remove this line to enable it: https://github.com/ghostfolio/ghostfolio/pull/3389/files#diff-c194725360f0243d507099d20e31d9c13c4c828d1c801eb5ae64b6518fbf795fR404
This pull request solves a problem where deleting all activities while having a filter applied would delete all activities instead of just the ones that are filtered. The issue has been fixed by adding filters to the deleteOrders method in the OrderController and OrderService classes. Now, only the filtered activities will be deleted.