Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix state of currency selector component (#2795) #3429

Conversation

SirZemar
Copy link
Contributor

  • Fix state of currency selector component

* Fix state of currency selector component
@dtslvr dtslvr linked an issue May 23, 2024 that may be closed by this pull request
@dtslvr dtslvr self-requested a review May 23, 2024 18:30
Copy link
Member

@dtslvr dtslvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks a bit cleaner now 👍🏻 There is one suggestion for refactoring in the template.

@dtslvr
Copy link
Member

dtslvr commented May 29, 2024

@SirZemar have you seen my feedback?

@SirZemar
Copy link
Contributor Author

I will take care of it, thank you @dtslvr for calling out to my attention.

Copy link
Member

@dtslvr dtslvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, @SirZemar!

While testing I found an issue in the account dialog and fixed it via aca6ccd. Ready to merge now.

@dtslvr dtslvr merged commit 60ef46a into ghostfolio:main Jun 1, 2024
2 checks passed
@SirZemar SirZemar deleted the bugfix/fix-state-of-currency-selector-component branch June 14, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix state of CurrencySelectorComponent
2 participants