Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support HAproxy proxy protocol v2 #207

Closed
wants to merge 5 commits into from

Conversation

Elbandi
Copy link
Contributor

@Elbandi Elbandi commented Jan 18, 2019

This patch allow enable haproxy proxy protocol (https://www.haproxy.org/download/1.8/doc/proxy-protocol.txt), so backend gets information about connection addresses

@CLAassistant
Copy link

CLAassistant commented Jan 18, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jan 18, 2019

Coverage Status

Coverage decreased (-0.3%) to 92.61% when pulling 3bdf0b7 on Elbandi:haproxy-protocol into a312726 on square:master.

@csstaub
Copy link
Member

csstaub commented Jan 18, 2019

Hi @Elbandi! Thanks so much for your pull request. I wasn't aware of this protocol, but it looks perfect for a proxy like Ghostunnel and I think we should definitely add support for this.

I think this kind of feature probably warrants adding a new integration test. Is there any way that we could set up an integration test running against HAProxy that verifies this implementation is (and stays) correct?

@csstaub
Copy link
Member

csstaub commented Jan 25, 2019

Thanks for adding a unit test. I will try to get this merged next week.

@csstaub
Copy link
Member

csstaub commented Feb 20, 2019

Merged in 8f78d6e

@csstaub
Copy link
Member

csstaub commented Feb 20, 2019

For some reason GitHub isn't picking up the merge, so I'll close this manually. Thank you for the pull request @Elbandi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants