Initial graphite/metrics support #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -51,7 +54,10 @@ var ( | |||
| allowAll = app.Flag("allow-all", "Allow all clients, do not check client cert subject.").Bool() | |||
| allowedCNs = app.Flag("allow-cn", "Allow clients with given common name (can be repeated).").PlaceHolder("CN").Strings() | |||
| allowedOUs = app.Flag("allow-ou", "Allow clients with organizational unit name (can be repeated).").PlaceHolder("OU").Strings() | |||
| statusPort = app.Flag("status-port", "Enable serving /_status on given localhost:PORT (shows tunnel/backend health status).").PlaceHolder("PORT").Int() | |||
| graphiteAddr = app.Flag("graphite", "Collect metrics and report them to the given graphite instance.").PlaceHolder("ADDR").TCP() | |||
| metricsURL = app.Flag("metrics-bridge", "Collect metrics and report them to the given URL (over HTTP/JSON).").PlaceHolder("URL").String() | |||
There was a problem hiding this comment.
--metrics-urls feels more readable instead of bridge.
There was a problem hiding this comment.
Agreed. I'll update this.
|
lgtm. Great job adding a test too 👍 |
|
Nice work 👍 |
csstaub
added a commit
that referenced
this pull request
Jan 26, 2016
Initial graphite/metrics support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r: @alokmenghrajani @mcpherrinm @sqshh
Initial graphite/metrics support. Collects metrics on accepted connections total, accepted connections success/failures, connection lifetime/duration, and open connection count.