Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of deprecated SecTrustGetCertificateAtIndex #426

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

csstaub
Copy link
Member

@csstaub csstaub commented Mar 23, 2024

Avoid use of deprecated SecTrustGetCertificateAtIndex. Replaces #420.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.42%. Comparing base (3a8fd6e) to head (c6b685e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   78.40%   78.42%   +0.02%     
==========================================
  Files          31       31              
  Lines        2135     2137       +2     
==========================================
+ Hits         1674     1676       +2     
  Misses        381      381              
  Partials       80       80              
Flag Coverage Δ
darwin 77.47% <100.00%> (+0.02%) ⬆️
linux 83.31% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csstaub
Copy link
Member Author

csstaub commented Mar 30, 2024

Tested, this worked fine for me.

Easy way to create test keys for this:

  • Open the Keychain Access app
  • Go to Keychain Access (menu) => Certificate Assistant => Create a Certificate
  • Create various certificates, certificate authorities, etc. whatever you want to test

@csstaub csstaub merged commit 1c3f1b2 into master Mar 30, 2024
11 checks passed
@csstaub csstaub deleted the cs/sec-trust-copy-cert branch March 30, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant