Windows: Support LOCAL_MACHINE and CURRENT_SERVICE #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 81.17% 81.21% +0.04%
==========================================
Files 35 35
Lines 1849 1853 +4
==========================================
+ Hits 1501 1505 +4
Misses 258 258
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
csstaub
force-pushed
the
cs/windows-local-machine
branch
2 times, most recently
from
b81f8dd
to
734113e
Compare
csstaub
changed the title
Add support for LOCAL_MACHINE and CURRENT_SERVICE keychains on Windows, because we might want to load our identities from there. We still prefer the CURRENT_USER keystore first and foremost. Also, this change adds additional logging for the certstore module.
csstaub
force-pushed
the
cs/windows-local-machine
branch
from
734113e
to
82de4f1
Compare
csstaub
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for LOCAL_MACHINE and CURRENT_SERVICE keychains on Windows, because we might want to load our identities from there. We still prefer the CURRENT_USER keystore first and foremost. Also, this change adds additional logging for the certstore module.
Work in progress -- opening this up here so I can run Windows tests on Github.