Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header wrong in Wiki #34

Closed
tomkooij opened this issue Dec 1, 2022 · 1 comment
Closed

Header wrong in Wiki #34

tomkooij opened this issue Dec 1, 2022 · 1 comment

Comments

@tomkooij
Copy link

tomkooij commented Dec 1, 2022

I can seem to edit or send a PR for a wiki page.

The header description on: seems wrong:
https://github.com/ghoti57/evofw3/wiki/Message-Body#message-body
The wiki states:

00 RQ
01 W
10 I
11 RP

However in the code:

static char const * const MsgType[4] = { "RQ", "I","W","RP" };

The order is: { "RQ", "I","W","RP" }
W and I seem to be swapped in the Wiki page.

Correct order according to the code:

00 RQ
01 I
10 W
11 RP

(I'm quite sure this is wrong in the Wiki, as I handcrafted a packetheader based on the wiki, and an I message was recieved as W by a real HGI80)

I'd be glad to submit a PR to the wiki, but can't figure out how.

@ghoti57
Copy link
Owner

ghoti57 commented May 12, 2023

Thanks, Wiki updated.

@ghoti57 ghoti57 closed this as completed May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants